[pbs-devel] [PATCH pbs 2/6] clippy fixes: the borrowed expression implements the required traits

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 16 09:56:12 CEST 2023


Am 16/06/2023 um 09:35 schrieb Maximiliano Sandoval:
> https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

missing newline here before S-o-b line

While at it, and no hard feelings here, but it could be good to have the core
information of the lint here directly, I don't like to chase links, especially
for minor things, and a lot go dead after a while,

E.g., as quote above the link, like:

> Why is this bad?
> Suggests that the receiver of the expression borrows the expression.


> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
>  src/api2/admin/datastore.rs    | 2 +-
>  src/api2/config/acme.rs        | 4 ++--
>  src/api2/tape/restore.rs       | 2 +-
>  src/auth.rs                    | 2 +-
>  src/config/mod.rs              | 4 ++--
>  src/config/tfa.rs              | 2 +-
>  src/server/jobstate.rs         | 2 +-
>  src/tape/drive/virtual_tape.rs | 8 ++++----
>  src/tape/encryption_keys.rs    | 2 +-
>  src/tape/media_catalog.rs      | 2 +-
>  src/tools/disks/mod.rs         | 2 +-
>  src/tools/disks/zfs.rs         | 2 +-
>  12 files changed, 17 insertions(+), 17 deletions(-)
> 






More information about the pbs-devel mailing list