[pbs-devel] applied: [PATCH proxmox-backup] ui: tape: fix restore datastore mapping parameter construction

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jun 6 13:14:35 CEST 2023


Am 06/06/2023 um 11:20 schrieb Dominik Csapak:
> We recently took into account the selected datastore when restoring from
> tape, but the snapshot grids value may not only be a single datastore, it can
> also be a list of snapshots, datastores or 'all'.
> 
> handle these cases and extract the source datastore correctly.
> 
> This fixes tape restoration when not a whole datastore is selected.
> 
> Reported in the forum:
> https://forum.proxmox.com/threads/restore-from-lto-parameter-verification-errors-store.128445
> 
> Fixes: df881ed0 ("ui: tape: fix restoring a single datastore")
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> this patch should also apply cleanly on the stable-2 branch currently
> 
>  www/tape/window/TapeRestore.js | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
>

applied, thanks!

A bit unrelated from this, but the code here would benefit IMO from ensuring
that for every variable/viewModel entry with datastore in its name, it is made
clear if that is talking about the source or the target...





More information about the pbs-devel mailing list