[pbs-devel] applied-series: [PATCH pbs 1/2] pbs-client: backup-writer: use log::warn instead of eprintln!

Fabian Grünbichler f.gruenbichler at proxmox.com
Wed Jul 19 11:08:31 CEST 2023


with the bug number fixed-up, and the (new) info message improved as
follow-up.

On June 7, 2023 4:07 pm, Maximiliano Sandoval wrote:
> The errors are not fatal so we only throw a warning.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
>  pbs-client/src/backup_writer.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs
> index be6da2a6..2e18a060 100644
> --- a/pbs-client/src/backup_writer.rs
> +++ b/pbs-client/src/backup_writer.rs
> @@ -293,7 +293,7 @@ impl BackupWriter {
>                          )
>                          .await
>                      {
> -                        eprintln!("Error downloading .fidx from previous manifest: {}", err);
> +                        log::warn!("Error downloading .fidx from previous manifest: {}", err);
>                      }
>                  }
>                  Ok(ArchiveType::DynamicIndex) => {
> @@ -305,7 +305,7 @@ impl BackupWriter {
>                          )
>                          .await
>                      {
> -                        eprintln!("Error downloading .didx from previous manifest: {}", err);
> +                        log::warn!("Error downloading .didx from previous manifest: {}", err);
>                      }
>                  }
>                  _ => { /* do nothing */ }
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 





More information about the pbs-devel mailing list