[pbs-devel] [PATCH proxmox-ldap 0/6] introduce proxmox-ldap crate

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jan 24 08:04:02 CET 2023


Am 23/01/2023 um 15:50 schrieb Lukas Wagner:
> Thanks for the review.
> 
> On 1/23/23 12:27, Thomas Lamprecht wrote:
>> Can you please sent a v3 that bases is on that repo and has Wolfgang's minor
>> comments addressed?
> 
> Sure!
> Since this series was a spin-off from my original LDAP series which *also* affected the `proxmox` repo
> in v2 as well: Should I merge both series for a common v3? Or should I keep them separate
> to keep the patch series a bit smaller/more manageable? What would you prefer?
> 

Separate is fine, as the crates in proxmox are all stand alone.

IMO the series separation was a good call, and merging the two series
due to them touching (partially) the same repos is not the best criteria,
at least on its own.





More information about the pbs-devel mailing list