[pbs-devel] applied: [PATCH proxmox-backup] fix #4483: fix `task log` command interrupt handling

[Thomas Lamprecht]

Am 18/01/2023 um 14:53 schrieb Fabian Grünbichler:
> `proxmox-backup-client task log ..` and `proxmox-backup-manager task log ..`
> are used to view the logs of tasks that have been started by another client, so
> interrupting the task progress view should not forward the interrupt to the
> running task. other call sites of the same helper(s) that spawn a task and then
> print its progress should keep the old behaviour of interrupting the spawned
> task on C^c.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
>  pbs-client/src/task_log.rs        | 26 +++++++++++++++++---------
>  proxmox-backup-client/src/task.rs |  2 +-
>  src/bin/proxmox-backup-manager.rs |  2 +-
>  3 files changed, 19 insertions(+), 11 deletions(-)
> 

> @@ -119,7 +127,7 @@ pub async fn view_task_result(
>      let data = &result["data"];
>      if output_format == "text" {
>          if let Some(upid) = data.as_str() {
> -            display_task_log(client, upid, true).await?;
> +            display_task_log(client, upid, true, true).await?;


the calling signature starts to become a bit opaque (mapping multiple booleans or
other immediate values has some overhead - without fancy LSP that is ;-)

But for now still somewhat fine.. applied, thanks!