[pbs-devel] [PATCH proxmox-backup 06/17] auth: add LDAP realm authenticator

[Thomas Lamprecht]

Am 04/01/2023 um 14:32 schrieb Wolfgang Bumiller:
>> +    fn store_password(&self, _username: &UsernameRef, _password: &str) -> Result<(), Error> {
>> +        // do not store password for LDAP users
>> +        Ok(())
> Actually this should fail.
> Otherwise this will make change-password API calls "succeed" without
> actually doing anything, but IMO it makes more sense to return a
> meaningful error there.
> 
> (Perhaps even a http_bail!(NOT_IMPLEMENTED) though I'm not really sure
> how the GUI would deal with that 😉 )
> 

Seems reasonable and the web UI should handle it just fine (ExtJS alert
window containing the message)