[pbs-devel] [PATCH v3 proxmox-backup 10/18] manager: add commands for managing LDAP realms

Lukas Wagner l.wagner at proxmox.com
Fri Feb 10 11:30:48 CET 2023


Thanks for the feedback, Fabian!

On 2/10/23 11:16, Fabian Grünbichler wrote:
>> +            proxmox_rest_server::handle_worker(upid).await?;
>> +        }
>> +    }
> 
> possibly late to the party given that the "handle_worker" move got applied already..
> 
> is there a good reason for introducing this instead of calling the endpoint over
> the API and using the "I just spawned a task and want to poll the output" helper
> (pbs_client::view_task_result), like the rest of proxmox-backup-manager does?
> 

Good point. I missed that the functionality was already present ;).
I used the debug-cli client as guidance, since that was what I was using for early
testing.

It would probably make sense to change it then?

-- 
- Lukas





More information about the pbs-devel mailing list