[pbs-devel] [PATCH proxmox-backup] fix #3921: client: confusing backup reader error

[Gabriel Goller]

Submitted v2.

On 9/1/23 10:02, Gabriel Goller wrote:
> When using the catalog shell command, a common error is that user pass
> "./files.pxar" instead of "files.pxar". This will result in a cryptic error
> "... value does not match regex pattern ...". Added some context to the
> error according to suggestions here [1].
>
> [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=3921
>
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
>   pbs-client/src/backup_reader.rs | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/pbs-client/src/backup_reader.rs b/pbs-client/src/backup_reader.rs
> index 2cd4dc27..138e836a 100644
> --- a/pbs-client/src/backup_reader.rs
> +++ b/pbs-client/src/backup_reader.rs
> @@ -98,7 +98,10 @@ impl BackupReader {
>       pub async fn download<W: Write + Send>(&self, file_name: &str, output: W) -> Result<(), Error> {
>           let path = "download";
>           let param = json!({ "file-name": file_name });
> -        self.h2.download(path, Some(param), output).await
> +        self.h2
> +            .download(path, Some(param), output)
> +            .await
> +            .map_err(|err| format_err!("http2 file download '{}' failed: \n{}", file_name, err))
>       }
>   
>       /// Execute a special GET request and send output to a writer