[pbs-devel] [PATCH v2 proxmox 1/1] fix #4995: compression: Include symlinks in zip file restore

[Filip Schauer]

Patch v3 available:

https://lists.proxmox.com/pipermail/pbs-devel/2023-December/007538.html

On 24/11/2023 12:03, Lukas Wagner wrote:
> On 11/24/23 08:56, Dominik Csapak wrote:
>> * if you want to go the extra mile, i guess this would be a good time 
>> to add tests
>>    that create a new zip from test data, to see if they don't break 
>> with your changes
>>
>
> I agree!
>
> I think writing tests for changes should be the default and not be 
> considered as 'the extra mile' - especially considering that it should 
> be relatively easy to write tests for this crate (no weird
> dependencies, no need to run as a certain user, etc.)
>