[pbs-devel] [PATCH proxmox-backup] tape: fix 'eject-before-unload' api type

Dietmar Maurer dietmar at proxmox.com
Thu Dec 14 09:18:24 CET 2023


> mhmm i modeled it after the 'tuning' options of the datastore.

Which is also clumsy and not really required... I would have used normal options instead...

> maybe it was named badly, and the 'options' should be replaced by 
> 'quirks' (as in, changer quirks that only some people need, like
> the datastore tuning options)
> 
> but if you both want a more straight forward option directly in
> the changer config, then it's also fine with me (i just

> did not want to pollute the changer config with rather
> specific quirk workarounds, and I doubt this is
> the last of them, even though we don't see such things often)

The changer config only has a few option, so we are far away from
a polluted config.

> just tell me if i should rename it to something else (like quirks)
> or if i should put it directly in the changer config, and i'll send
> the patches for it + docs update

Yes, please use normal options unless there is a real requirement to
use a property string.




More information about the pbs-devel mailing list