[pbs-devel] applied: [PATCH v2 proxmox-backup 0/2] Fix DatastoreListSummary on limited permissions

Dietmar Maurer dietmar at proxmox.com
Mon Dec 11 13:13:40 CET 2023


applied, thanks!

> On 11.12.2023 09:59 CET Gabriel Goller <g.goller at proxmox.com> wrote:
> 
>  
> When the user has limited permissions on a datastore (e.g `NoAccess` on the whole 
> datastore and `DatastoreBackup` on a namespace inside the datastore) the Datastore
> List shows weird values. 
> 
> Instead of returning -1 we return an Option and handle missing values on the
> frontend.
>   
> Changes version 2:
>  - Use u64 instead of i64, as value is never negative.
> 
> 
> 
> proxmox-backup:
> 
> Gabriel Goller (2):
>   ui: datastore summary handle non-existent values
>   status: use Option on avail/used datastore attrs
> 
>  pbs-api-types/src/datastore.rs        | 19 +++++++++++--------
>  src/api2/status.rs                    |  6 +++---
>  www/datastore/DataStoreListSummary.js | 20 ++++++++++++++------
>  3 files changed, 28 insertions(+), 17 deletions(-)
> 
> 
> Summary over all repositories:
>   3 files changed, 28 insertions(+), 17 deletions(-)
> 
> -- 
> murpp v0.4.0
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




More information about the pbs-devel mailing list