[pbs-devel] [PATCH v3 proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs

Gabriel Goller g.goller at proxmox.com
Wed Dec 6 14:37:23 CET 2023


LGTM!

Tested-by: Gabriel Goller <g.goller at proxmox.com>
Reviewed-by: Gabriel Goller <g.goller at proxmox.com>

On 12/6/23 12:31, Christian Ebner wrote:
> Warn about a missing garbage collection schedule, prune job or verify
> job configurations in the datastore's summary panel.
>
> Show the number of prune/verify job configurations, if there are jobs
> configured.
>
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 2:
> - move message string initialization to controllers `init` function
>
> changes since version 1:
> - add check mark icon for configured jobs/schedule
> - add question mark icon for unknown configuration state
> - fix typo in garbage collection variable name
> - add missing trailing commas found by pve-eslint
> - refactor message initialization to allow to use format helper
>    functions
>   www/datastore/Summary.js | 96 ++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 96 insertions(+)
>
> [..]




More information about the pbs-devel mailing list