[pbs-devel] [PATCH proxmox-backup v2 0/4] add 'show information' for snapshots

Dominik Csapak d.csapak at proxmox.com
Tue Dec 5 11:53:41 CET 2023


includes the upload statistics. This also moves some actions from the
column directly into a 'hamburger menu' so we don't overload the grid.

The only downside to this currently is that i could get keyboard
navigation to work for the context menu or the hamburger menu, but i'm
still looking into this.

changes from v1:
* renamed 'group-notes' to 'group-comment' to be consistent with the
  'comment' field
* added the (group)comment as tabs where the files lists are
* moved the files/comment tabpanel to the bottom
* made the window a bit wider, and put the upload statistics and
  verification info side by side, this way we save a bit vertical space
  (needed since the tabpanel takes a bit more)

continuation for the context menu series[0]
(changes title due to the context menu patch being applied)

0: https://lists.proxmox.com/pipermail/pbs-devel/2023-November/007248.html

Dominik Csapak (4):
  api-types: add an UploadStatistic api type
  api: datastore admin: add 'snapshot-information' api call
  ui: datastore content: add snapshot information to context menu
  ui: datastore content: add 'more actions' menu to actions

 pbs-api-types/src/datastore.rs |  40 +++++
 src/api2/admin/datastore.rs    | 117 ++++++++++++++-
 www/Makefile                   |   1 +
 www/datastore/Content.js       | 130 +++++++++++------
 www/window/SnapshotInfo.js     | 259 +++++++++++++++++++++++++++++++++
 5 files changed, 493 insertions(+), 54 deletions(-)
 create mode 100644 www/window/SnapshotInfo.js

-- 
2.30.2





More information about the pbs-devel mailing list