[pbs-devel] [PATCH proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs

Christian Ebner c.ebner at proxmox.com
Mon Dec 4 17:09:54 CET 2023


> On 04.12.2023 16:42 CET Gabriel Goller <g.goller at proxmox.com> wrote:
> 
> Small typo here... This should say `gcScheduleMsg`.

Ah yes, thanks for noticing, will be fixed in a new version.

> How about we put a green checkmark here (and on the other lines below)? 
> Otherwise this wall of text looks kinda bleak :(
> We could add the `fa fa-check-circle` icon with the `good` (color: 
> green) class?

Hmm, not to sure about that one, I deliberately did not emphasize the
message in case there are jobs configured, keeping the output rather
neutral. But I am open for opinions on this one.

However, I will include the question mark icon in case of the unknown
job config state. The main focus should be on possibly missing job
configurations, configured jobs might still have issues and need to be
checked in the tasks logs.

> 
> 
> There are also a few linting issues:
> 
> 3 issues marked with (*) could be auto-fixed using '--fix'.
> [./datastore/Summary.js]:
> WARN: line 123 col 4: comma-dangle - Missing trailing comma. (*)
> WARN: line 138 col 4: comma-dangle - Missing trailing comma. (*)
> WARN: line 153 col 4: comma-dangle - Missing trailing comma. (*)

Yes, missed those as well, will be fixed in a new version.

Thank you for your comments!




More information about the pbs-devel mailing list