[pbs-devel] [PATCH proxmox] client/login: clippy fixes

Max Carrara m.carrara at proxmox.com
Mon Aug 21 13:48:15 CEST 2023


Signed-off-by: Max Carrara <m.carrara at proxmox.com>
---
 proxmox-client/src/lib.rs | 4 ++--
 proxmox-login/src/tfa.rs  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/proxmox-client/src/lib.rs b/proxmox-client/src/lib.rs
index 4da079d..06f57ff 100644
--- a/proxmox-client/src/lib.rs
+++ b/proxmox-client/src/lib.rs
@@ -85,13 +85,13 @@ impl HttpApiResponse {
         match self.content_type.as_deref() {
             Some("application/json") => Ok(()),
             Some(other) => {
-                return Err(Error::BadApi(
+                Err(Error::BadApi(
                     format!("expected json body, got {other}",),
                     None,
                 ))
             }
             None => {
-                return Err(Error::BadApi(
+                Err(Error::BadApi(
                     "expected json body, but no Content-Type was sent".to_string(),
                     None,
                 ))
diff --git a/proxmox-login/src/tfa.rs b/proxmox-login/src/tfa.rs
index 9f40589..afe44d1 100644
--- a/proxmox-login/src/tfa.rs
+++ b/proxmox-login/src/tfa.rs
@@ -71,7 +71,7 @@ mod bytes_as_base64url_nopad {
     pub fn deserialize<'de, D: Deserializer<'de>>(deserializer: D) -> Result<Vec<u8>, D::Error> {
         use serde::de::Error;
         String::deserialize(deserializer).and_then(|string| {
-            base64::decode_config(&string, base64::URL_SAFE_NO_PAD)
+            base64::decode_config(string, base64::URL_SAFE_NO_PAD)
                 .map_err(|err| Error::custom(err.to_string()))
         })
     }
--
2.39.2






More information about the pbs-devel mailing list