[pbs-devel] [PATCH proxmox-backup v3 0/6] local sync-jobs

Hannes Laimer h.laimer at proxmox.com
Tue Aug 8 14:13:38 CEST 2023


Add support for local sync. SyncJobs without a remote are considered local, and
use a different logic for pulling. In the course of adding the extra pull logic,
the pull code was rewritten to basically be source independent. Also cli
completion and the UI was updated to allow Remotes in SyncJobs to be optional.

v2, thanks @Fabian Grünbichler <f.gruenbichler at proxmox.com> for the feedback and
suggestions on v1.
 - make pull logic more source independent

v3: thanks @Fabian and @Wolfang for the feedback on v2
 - remove enums for Local/Remote
 - use traits, pull logic now expects a `dyn PullSource`(or `dyn PullReader`)
 - add lock to dir for local sync
 - split refactoring of pull logic and implementation of
    local pulling into two commits

Hannes Laimer (6):
  api2: make Remote for SyncJob optional
  ui: add support for optional Remote in SyncJob
  manager: add completion for opt. Remote in SyncJob
  accept a ref to a HttpClient
  pull: refactor pulling from a datastore
  pull: add support for pulling from local datastore

 Cargo.toml                           |    2 +
 examples/download-speed.rs           |    2 +-
 pbs-api-types/src/jobs.rs            |    5 +-
 pbs-client/src/backup_reader.rs      |    2 +-
 pbs-datastore/src/read_chunk.rs      |    2 +-
 proxmox-backup-client/src/catalog.rs |    4 +-
 proxmox-backup-client/src/main.rs    |    2 +-
 proxmox-backup-client/src/mount.rs   |    2 +-
 proxmox-file-restore/src/main.rs     |    4 +-
 src/api2/config/remote.rs            |   16 +-
 src/api2/config/sync.rs              |   41 +-
 src/api2/node/tasks.rs               |    4 +-
 src/api2/pull.rs                     |   45 +-
 src/bin/proxmox-backup-manager.rs    |   67 +-
 src/bin/proxmox_backup_debug/diff.rs |    2 +-
 src/server/email_notifications.rs    |   18 +-
 src/server/pull.rs                   | 1080 ++++++++++++++++----------
 www/form/RemoteTargetSelector.js     |   29 +-
 www/window/SyncJobEdit.js            |    8 +-
 19 files changed, 846 insertions(+), 489 deletions(-)

-- 
2.39.2






More information about the pbs-devel mailing list