[pbs-devel] [PATCH proxmox-backup] fix #4380: check permissions before entering directory

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Aug 4 17:49:47 CEST 2023

just some higher-level process review:

please use a v2 tag if it's the second version, both git format-patch and
git send-email support adding that conveniently using -v2 (or -v3 and so
one if a later revision).

Am 04/08/2023 um 12:02 schrieb Gabriel Goller:
> When creating a backup, we now check if we have the correct permissions
> (r,x) before entering a directory. This is mainly to prevent stat() from
> failing with EACCESS errors. We also check if the directory contains
> non-excluded files and warn the user.
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---

please add a series changelog here, i.e., outside of what gets added to git
but easily discoverable. E.g., like:

changes v1:
- ...

See https://pve.proxmox.com/wiki/Developer_Documentation#Preparing_Patches

and btw., as I observed it in a reply to Fiona in the v1 of this fix: please
ensure you use "reply all" when replying, so that the mailing list stays

More information about the pbs-devel mailing list