[pbs-devel] [PATH proxmox-backup] fix #4380: stat() is run when file is executed

Fiona Ebner f.ebner at proxmox.com
Fri Aug 4 09:42:40 CEST 2023


Am 03.08.23 um 17:22 schrieb Gabriel Goller:
> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
> index 2577cf98..c573c2a3 100644
> --- a/pbs-client/src/pxar/create.rs
> +++ b/pbs-client/src/pxar/create.rs
> @@ -434,6 +434,15 @@ impl Archiver {
>              assert_single_path_component(os_file_name)?;
>              let full_path = self.path.join(os_file_name);
>  
> +            let match_path = PathBuf::from("/").join(full_path.clone());
> +            if self
> +                .patterns
> +                .matches(match_path.as_os_str().as_bytes(), None)

Is it fine to call matches() without the file mode in all cases? Can't
it make a difference for directory matching? If it's okay, please
explain why in the commit message.





More information about the pbs-devel mailing list