[pbs-devel] [PATCH proxmox-backup 3/3] ui: datastore content: add action to show upload statistics

Dominik Csapak d.csapak at proxmox.com
Tue Aug 1 11:29:54 CEST 2023


inspired by how we show volume statistics for tape drives

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
we could also add it as a tooltip somewhere else, eg the size column

also, this pattern for the window could be refactored into a
'keyvalueinfowindow' (or something like that), since we already use that
pattern a few time

 www/datastore/Content.js | 56 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 9fc07d49..bb2d76ee 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -711,6 +711,56 @@ Ext.define('PBS.DataStoreContent', {
 	    });
 	},
 
+	showUploadStatistics: function(view, rI, cI, item, e, rec) {
+	    let me = this;
+
+	    let list = [];
+
+	    let keyMap = {
+		count: gettext('Chunk Count'),
+		duplicates: gettext('Duplicate Chunks'),
+		size: gettext('Size'),
+		compressed_size: gettext('Compressed Size'),
+	    };
+
+	    for (let [key, val] of Object.entries(rec.data['upload-statistic'])) {
+		if (key === 'size' || key === 'compressed_size') {
+		    val = Proxmox.Utils.format_size(val);
+		}
+
+		list.push({ key: keyMap[key] ?? key, value: val });
+	    }
+
+	    Ext.create('Ext.window.Window', {
+		title: gettext('Upload Statistics'),
+		modal: true,
+		width: 600,
+		height: 250,
+		layout: 'fit',
+		scrollable: true,
+		items: [
+		    {
+			xtype: 'grid',
+			store: {
+			    data: list,
+			},
+			columns: [
+			    {
+				text: gettext('Property'),
+				dataIndex: 'key',
+				flex: 1,
+			    },
+			    {
+				text: gettext('Value'),
+				dataIndex: 'value',
+				flex: 1,
+			    },
+			],
+		    },
+		],
+	    }).show();
+	},
+
 	onForget: function(table, rI, cI, item, e, { data }) {
 	    let me = this;
 	    let view = this.getView();
@@ -974,6 +1024,12 @@ Ext.define('PBS.DataStoreContent', {
 		    },
 		    isActionDisabled: (v, r, c, i, rec) => rec.data.ty !== 'dir',
 		},
+		{
+		    handler: 'showUploadStatistics',
+		    getTip: (v, m, rec) => Ext.String.format(gettext("Show Upload Statistics of '{0}'"), v),
+		    getClass: (v, m, rec) => rec.data.ty === 'dir' ? 'fa fa-info-circle' : 'pmx-hidden',
+		    isActionDisabled: (v, r, c, i, rec) => rec.data.ty !== 'dir',
+		},
 		{
 		    handler: 'onForget',
 		    getTip: (v, m, { data }) => {
-- 
2.30.2






More information about the pbs-devel mailing list