[pbs-devel] [pve-devel] [PATCH proxmox-backup] fix #4165: SMART: add raw field

Dominik Csapak d.csapak at proxmox.com
Thu Sep 22 12:35:30 CEST 2022


all 3 patches LGTM

the only (minor) thing is that the wt patch could have handled the current situation
(pve raw+value, pbs normalized+value), e.g by using the field 'convert' or 'calculate'
methods of extjs (we could have had a 'real_raw' and 'real_normalized' that uses
the values depending on which exist) then we would not need a depends/breaks on the
versions (not sure which direction here)

if everybody else is ok with these dependencies, consider these patches:

Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
Tested-by: Dominik Csapak <d.cspak at proxmox.com>





More information about the pbs-devel mailing list