[pbs-devel] applied: [PATCH proxmox-backup] pbs-manager: fix pull not respecting local ns setting

[Thomas Lamprecht]

Am 20/09/2022 um 13:18 schrieb Fabian Grünbichler:
> On September 20, 2022 12:48 pm, Thomas Lamprecht wrote:
>> Am 20/09/2022 um 12:43 schrieb Fabian Grünbichler:
>>> On September 20, 2022 12:24 pm, Thomas Lamprecht wrote:
>>>> Am 20/09/2022 um 12:19 schrieb Fabian Grünbichler:
>>>>> thanks for the quick fix!
>>>>
>>>> You were quicker (I wanted to amend the commit message a bit) and currently
>>>> wondering why that POST call went through anyway, as the extra unknown
>>>> parameter should cause a higher level error?
>>>
>>> I was looking in parallel based on the forum report and then saw the 
>>> patch coming in ;)
>>>
>>> the API defaults to (silently) allowing additional properties, which is 
>>> why this is neither an error nor logged anywhere. this behaviour comes 
>>> from PVE IIRC.
>>
>> That normally should require a explicit `additional_properties: true,` which
>> we do not set here. The ObjectSchema has it set to false by default and PVE's
>> default is also false IIRC, resulting in a 400 error..
>>
> 
> parameters here is an AllOfSchema, and that unconditionally allows 
> additional properties.

yuck, that is ugly