[pbs-devel] [PATCH proxmox-backup v2 5/5] datastore: make 'filesystem' the default sync-level
Dominik Csapak
d.csapak at proxmox.com
Fri Oct 7 13:54:49 CEST 2022
Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
docs/storage.rst | 4 ++--
pbs-api-types/src/datastore.rs | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/storage.rst b/docs/storage.rst
index d7e19ec1..8b326261 100644
--- a/docs/storage.rst
+++ b/docs/storage.rst
@@ -344,13 +344,13 @@ and only available on the CLI:
the crash resistancy of backups in case of a powerloss or hard shutoff.
There are currently three levels:
- - `none` (default): Does not do any syncing when writing chunks. This is fast
+ - `none` : Does not do any syncing when writing chunks. This is fast
and normally ok, since the kernel eventually flushes writes onto the disk.
The kernel sysctls `dirty_expire_centisecs` and `dirty_writeback_centisecs`
are used to tune that behaviour, while the default is to flush old data
after ~30s.
- - `filesystem` : This triggers a ``syncfs(2)`` after a backup, but before
+ - `filesystem` (default): This triggers a ``syncfs(2)`` after a backup, but before
the task returns `OK`. This way it is ensured that the written backups
are on disk. This is a good balance between speed and consistency,.
Note that the underlying storage device sitll needs to protect itself against
diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index 15ea80cd..f33fbc2d 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -200,7 +200,7 @@ pub enum DatastoreFSyncLevel {
impl Default for DatastoreFSyncLevel {
fn default() -> Self {
- DatastoreFSyncLevel::None
+ DatastoreFSyncLevel::Filesystem
}
}
--
2.30.2
More information about the pbs-devel
mailing list