[pbs-devel] applied: [PATCH v3 proxmox-backup] prune-simulator: allow setting a custom date/time
Thomas Lamprecht
t.lamprecht at proxmox.com
Wed Oct 5 17:01:07 CEST 2022
Am 20/09/2022 um 15:21 schrieb Matthias Heiserer:
> With this, the prune simulator will be more flexible, which might clear
> up questions such as these:
> https://forum.proxmox.com/threads/pbs-prune-simulator-monthly-backups.115081
>
> In order to have the configuration window not take up too much space,
> I added another column and moved the border to the left.
>
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
> Thanks to fiona for the many suggestions!
>
> CHANGES FROM v2:
> use getDate (gives day of month) instead of getDay (day of week)
> change instead of select, and check that input is valid
> use Y-m-d in date selector to stay consistent with rest of page
> include backup happening at selected time in simulation
> slightly reworded commit message
>
> CHANGES FROM v1:
> squash patches
> wider column so no fields are cut off
> smaller year/time labels
> use viewmodel instead of `const NOW`
> improve patch title
> 24h (hh:mm) format for time
>
> .../prune-simulator/prune-simulator_source.js | 151 +++++++++++++-----
> 1 file changed, 109 insertions(+), 42 deletions(-)
>
>
applied, with Fiona's T-b and R-b tags, thanks!
I reworked the layout of the whole simulation options panel in a few follow ups though,
not really related directly to your patch, it just made me retake a closer look on the
whole thing. Please holler if something broke.
More information about the pbs-devel
mailing list