[pbs-devel] applied-series: [PATCH proxmox-backup v2 1/2] tape: hide internal use of all zero uuid for unassigned tapes

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 30 17:32:35 CET 2022


Am 29/11/2022 um 15:17 schrieb Dominik Csapak:
> a tape assigned to a pool but no media-set, gets the special 'all zero'
> media set in it's MediaSetLabel. Instead of having that constant
> scattered all over the code, hide this fact by using wrapper functions
> to initialize it that way and to check for it
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> replaces my previous patch:
>  tape: refactor uuid of empty media set into constant
> 
>  src/api2/tape/drive.rs       |  6 +++---
>  src/api2/tape/media.rs       |  3 +--
>  src/tape/file_formats/mod.rs |  8 ++++++++
>  src/tape/inventory.rs        | 26 +++++++++++---------------
>  src/tape/media_pool.rs       |  2 +-
>  5 files changed, 24 insertions(+), 21 deletions(-)
> 
>

applied both patches, thanks!

ps. I like those commit subjects/messages, many thanks for making my work
slightly easier (it adds up).





More information about the pbs-devel mailing list