[pbs-devel] applied: [PATCH proxmox-backup] disk: smartctl: ignore bit 2 of exitcode

[Wolfgang Bumiller]

applied, thanks

On Thu, Nov 24, 2022 at 11:17:09AM +0100, Dominik Csapak wrote:
> under some conditions, the smartctl exitcode sets bit 2, even if the
> smartctl call succeeded, but has e.g. some warnings derived from the
> attributes
> 
> we do the same in pve, but it is only the first step in fixing #4353, since
> we probably should parse the smartcl output better to include
> such warnings
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  src/tools/disks/smart.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/tools/disks/smart.rs b/src/tools/disks/smart.rs
> index 180ddfe9..a99404dc 100644
> --- a/src/tools/disks/smart.rs
> +++ b/src/tools/disks/smart.rs
> @@ -94,7 +94,7 @@ pub fn get_smart_data(disk: &super::Disk, health_only: bool) -> Result<SmartData
>      let output = proxmox_sys::command::run_command(
>          command,
>          Some(
> -            |exitcode| (exitcode & 0b0111) == 0, // only bits 0-2 are fatal errors
> +            |exitcode| (exitcode & 0b0011) == 0, // only bits 0-1 are fatal errors
>          ),
>      )?;
>  
> -- 
> 2.30.2