[pbs-devel] [PATCH proxmox-backup] ui: prune job edit: fix disabling jobs

Fiona Ebner f.ebner at proxmox.com
Wed Nov 16 10:41:40 CET 2022


Am 15.11.22 um 15:29 schrieb Thomas Lamprecht:
> Am 14/11/2022 um 10:42 schrieb Fiona Ebner:
>> The backend doesn't have an 'enable' option, but 'disable'. Could be
>> converted before sending and after loading, but it's cleaner to just
>> align it with the backend.
> 
> while it is cleaner code-wise, its worse UX-wise; as checking (=enabling) a
> "negative" option like disable is always a bit odd and in general a bit less
> intuitive.
> 
> I replaced this by a patch that converts it on load/before send to keep the
> "Enable" display.

Makes sense, thanks! For PBS 3.0, should we align it with sync and
verify jobs where the schedule is optional (so disabled if no schedule
is set)? That would close #4342.





More information about the pbs-devel mailing list