[pbs-devel] [PATCH proxmox-backup/common/storage v4] improve file-restore timeout behaviour

Dominik Csapak d.csapak at proxmox.com
Thu Nov 10 11:36:28 CET 2022


this series improves the behaviour of the file-restore when some mount
operations take longer than the 30 second pveproxy timeout

and enables/disables the automatic increasing of memory depending
on the users privileges

depends (i'll add it to the seperate patches too)
pve-storage 1/3 fixes the currently broken error output and
does not depend on the rest of the series
pve-storage 2/3 depends on pve-common 1/2
pve-storage 3/3 depends on pve-common 2/2
pve-common 2/2 depends on proxmox-backup

changes from v3:
* don't hardcode the timeout parameter in pve-common, but make it a
  hash were we explicitely extract the timeout
* split the pve-storage commit into two, one for handling the error
  format and one for the timeout
* add patches to handle the dynamic memory behaviour

changes from v2:
* couple the error format to 'ouput-format' instead of 'json-error'
* remove 'error' property from 'error json object' (was redundant)
* always expect an error when we get an object and always treat
  it as ok when we get a list

changes from v1:
* rebased on master
* moved the json-error and timeout directly into pve-common (hardcoded)
  since there is only one usage of that function

proxmox-backup:

Dominik Csapak (1):
  file-restore: make dynamic memory behaviour controllable

 proxmox-file-restore/src/block_driver.rs      | 10 +++-
 proxmox-file-restore/src/block_driver_qemu.rs |  6 ++-
 proxmox-file-restore/src/main.rs              | 54 +++++++++++++++++--
 3 files changed, 61 insertions(+), 9 deletions(-)

pve-common:

Dominik Csapak (2):
  PBSClient: file_restore_list: add extraParams and use timeout
  PBSClient: add optional 'dynamic-memory' parameter to file-restore
    commands

 src/PVE/PBSClient.pm | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

pve-storage:

Dominik Csapak (3):
  api: FileRestore: decode and return proper error of file-restore
    listing
  api: FileRestore: make use of file-restores and guis timeout mechanism
  api: FileRestore: allow automatic memory increase for privileged users

 PVE/API2/Storage/FileRestore.pm | 48 +++++++++++++++++++++++++++------
 1 file changed, 40 insertions(+), 8 deletions(-)

-- 
2.30.2






More information about the pbs-devel mailing list