[pbs-devel] [PATCH proxmox-backup 4/5] ui: datastore/Summary: change storage axis to power of two

[Thomas Lamprecht]

Am 5/17/22 um 10:20 schrieb Dominik Csapak:
> On 5/17/22 10:09, Thomas Lamprecht wrote:
>> Am 5/17/22 um 08:52 schrieb Dominik Csapak:
>>> so that the unit is the same as in the overview panel on the same page
>>>
>>
>> This missed the administration Server Status RRD for the root disk, but actually
>> this needs to be the other way around, I switched to power of two for all memory
>> graphs in PVE 7.0 and the storage one to power of ten, at least the pve storages,
>> the root HD one in the node summary is still wrong (will fix).
>>
>>
> 
> yeah you're right, i forgot about the administration rrd panels.
> 
> any reason why we use different units for disk vs memory?

because they're two different things usage wise, due to memory being tied to the CPU
a power of two address and thus size comes just naturally, and the industries tradition
is to advertised and base 10 for storage, where it doesn't really matter from a technical
POV but from a marketing (bigger number for SI)

> imho storage also often uses binary units.

cannot remember to see any disk sold with a advertised size formatted as power of
two, and users may be confused if they see less capacity than the disk promised.

> 
> (`lvs`/`lsblk` uses that in it's default output, we use it
> for vm/ct disks, etc.)

we show SI units for the disk panel, it should rather fit that, also we nowhere
show LVM in PBS, nor will we ever be able to show the same thing that all filesystem/
olume manager techs do, IMO also a bogus goal, what's important is to be consistent,
which we never really had, it was always a weird mix of either, and especially the
base ten for memory, which results in values on axis that just don't line nicely
up has done it for me for the 6.4 release there.