[pbs-devel] [PATCH proxmox-backup] ui: datastore/Summary: correctly show the io-delay chart

Dominik Csapak d.csapak at proxmox.com
Tue May 17 09:00:38 CEST 2022


by checking if *any* record has data, not only the first
this would prevent the chart from being shown for e.g. newly added
datastores, or for datastores after the server was offline for some time

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/datastore/Summary.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
index 3c07d512..a24b10a8 100644
--- a/www/datastore/Summary.js
+++ b/www/datastore/Summary.js
@@ -312,7 +312,8 @@ Ext.define('PBS.DataStoreSummary', {
 	});
 
 	me.mon(me.rrdstore, 'load', function(store, records, success) {
-	    me.down('#ioDelayChart').setVisible(!success || records[0]?.data?.io_ticks !== undefined);
+	    let has_io_ticks = records.some((rec) => rec?.data?.io_ticks !== undefined);
+	    me.down('#ioDelayChart').setVisible(!success || has_io_ticks);
 	}, undefined, { single: true });
 
 	me.query('proxmoxRRDChart').forEach((chart) => {
-- 
2.30.2






More information about the pbs-devel mailing list