[pbs-devel] applied: [PATCH proxmox-backup v2] chunk_store: insert_chunk: write chunk again if it is empty on disk

[Thomas Lamprecht]

Am 5/9/22 um 16:09 schrieb Dominik Csapak:
> and issue a warning. We can do this, because we know an empty chunk cannot be
> valid, and we (assumedly) have a valid chunk in memory.
> 
> Having empty chunks on disk is currently possible when PBS crashes, but the
> rename of the chunk was flushed to disk, when the actual data was not.
> 
> If it's not empty but there is a size mismatch, return an error.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> replaces: https://lists.proxmox.com/pipermail/pbs-devel/2022-May/005042.html
> 
> changes from v1:
> * warn only on old_size == 0
> * fix old_size/new_size
> * expand commit message
> 
> we could do further checks here, but those should be caught by verify.
> the 'real' fix for most of the 0-size chunks will be to either fsync
> the chunks after write/rename, or do a syncfs before the backup ends
> 
>  pbs-datastore/src/chunk_store.rs | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 
>

applied, thanks!