[pbs-devel] [PATCH proxmox-backup] proxy: rrd: skip update disk stats for offline datastores

Hannes Laimer h.laimer at proxmox.com
Wed May 4 07:49:06 CEST 2022


RDD update did not use lookup_datastore() and therefore bypassed
the maintenance mode checks. This adds the needed check directly.

Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
---
 src/bin/proxmox-backup-proxy.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs
index 6a305b7c..c71d0009 100644
--- a/src/bin/proxmox-backup-proxy.rs
+++ b/src/bin/proxmox-backup-proxy.rs
@@ -1071,6 +1071,12 @@ fn generate_host_stats_sync() {
                 .unwrap_or_default();
 
             for config in datastore_list {
+                if config
+                    .get_maintenance_mode()
+                    .map_or(false, |mode| mode.check(Some(Operation::Read)).is_err())
+                {
+                    continue;
+                }
                 let rrd_prefix = format!("datastore/{}", config.name);
                 let path = std::path::Path::new(&config.path);
                 gather_disk_stats(disk_manager.clone(), path, &rrd_prefix);
-- 
2.30.2






More information about the pbs-devel mailing list