[pbs-devel] applied: [PATCH v2] proxmox-backup-proxy: stop accept() loop on daemon shutdown

Thomas Lamprecht t.lamprecht at proxmox.com
Mon May 2 14:21:03 CEST 2022


Am 4/29/22 um 12:04 schrieb Dominik Csapak:
> When a task was running during a reload, the old process would still
> accept connections, but drop them due to the closed receiving channel.
> 
> This resulted in sporadic connection failures in such a scenario,
> depending on which process got the connection.
> 
> To fix that poll the shutdown_future too during accept, and exit the
> loop then.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * only get the shutdown_future once and reuse it in the loop
>  src/bin/proxmox-backup-proxy.rs | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
>

applied, thanks!

Added some more (root cause) info to the commit message and noted that
this alone doesn't explains the "why did it pop up *now*" question.





More information about the pbs-devel mailing list