[pbs-devel] [pve-devel] [PATCH proxmox-backup v3 3/6] fix #3607: ui: add a separate notes view for longer markdown notes

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Mar 23 12:08:28 CET 2022


On 04.03.22 12:31, Stefan Sterz wrote:
> since markdown notes might be rather long, this commit adds a tab
> similar to pve's datacenter or node notes.
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
>  www/Makefile               |   2 +
>  www/NavigationTree.js      |   6 ++
>  www/NodeNotes.js           |  22 +++++++
>  www/panel/MarkdownNotes.js | 130 +++++++++++++++++++++++++++++++++++++
>  4 files changed, 160 insertions(+)
>  create mode 100644 www/NodeNotes.js
>  create mode 100644 www/panel/MarkdownNotes.js
> 

> diff --git a/www/panel/MarkdownNotes.js b/www/panel/MarkdownNotes.js
> new file mode 100644
> index 00000000..6d601401
> --- /dev/null
> +++ b/www/panel/MarkdownNotes.js> @@ -0,0 +1,130 @@
> +Ext.define('PBS.panel.MarkdownNotes', {
> +    extend: 'Ext.panel.Panel',
> +    xtype: 'pbsMarkdownNotes',
> +    mixins: ['Proxmox.Mixin.CBind'],
> +

why add this if we move a almost identical one to widget toolkit?

If there are some changes required that cannot be easily passed via a config, we should still
reuse most by extending the NotesView wtk component, and not panel.Panel




More information about the pbs-devel mailing list