[pbs-devel] [PATCH proxmox-backup] pbs-datastore: use ConfigVersionCache for datastore

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 1 09:53:01 CET 2022


On 28.02.22 07:51, Dominik Csapak wrote:
> On 2/25/22 16:25, Dietmar Maurer wrote:
>>> but on the other hand, we now basically create a new datastore object
>>> every minute
>>
>> And you think this is a problem (why)?
> 
> it seems unnecessary, and if it was not a problem, why didn't we do it before?
> we already read/parsed the config anyway....
> 
> i assumed that there was a good reason not to construct a new object
> every time, but i did not find it
> 

Yeah I also do not get this, especially as there's zero info about "why"
and the benefits in the commit message - that's more important than
describing the diff that is attached to the commit anyway (not that this
cannot help but focus should be on the former).

Any benchmarking, timing assumptions or other things done? As more and
more complex code should have /some/ arguing in favor of it sent along..




More information about the pbs-devel mailing list