[pbs-devel] applied: [PATCH proxmox-backup] restore-daemon: make file listing 'streaming'

Wolfgang Bumiller w.bumiller at proxmox.com
Tue Jun 21 10:48:17 CEST 2022


applied, thanks

On Mon, Jun 20, 2022 at 09:51:13AM +0200, Dominik Csapak wrote:
> this prevents an oom kill when listing large directories.
> Without this, i'd get an oom kill in the restore vm when
> i tried to list a directory with ~60000 entries, but with this,
> i'd get the response for even 250000 entries
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> at 250000 files, the gui did not work anymore, but that's a different
> problem altogether (i got 'Maximum call stack size exceeded' in extjs code)
> 
>  proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> index aeb5a71d..91afe5e3 100644
> --- a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> +++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs
> @@ -116,6 +116,7 @@ fn get_dir_entry(path: &Path) -> Result<DirEntryAttribute, Error> {
>  }
>  
>  #[api(
> +    streaming: true,
>      input: {
>          properties: {
>              "path": {
> -- 
> 2.30.2





More information about the pbs-devel mailing list