[pbs-devel] applied-series: [PATCH proxmox-backup/proxmox-widget-toolkit v2 0/4] add partitions to disks/list endpointg

[Wolfgang Bumiller]

applied series, thanks

On Wed, Jun 08, 2022 at 08:51:50AM +0000, Hannes Laimer wrote:
> In order to work with the existing frontend component for displying the
> disklist, either
> * the partition data has to be return with the same struct a disk is
>   returned. Which leads to the same struct being used for different
>   things -> quite a few fields are always empty for partitions and a new
>   'type' field would be needed. Also the code structure in PBS has to be
>   changed quite a bit.
> * the existing frontend has to be adjusted to handle data from PVE and
>   PBS properly.
> 
> I went with the second option because the adjustments nedded in the UI
> compenent were minimal and, IMHO, adjusting the API to fit the UI is the
> wrong direction.
> 
> For the mount status to shown in the UI, the patch[1] sent to pve-devel for
> the 'mounted' column is needed.
> 
> NOTE: The partition data will be needed in later patches for removable
> datastores.
> 
> v1->v2:
>  * use builder pattern for queries as suggested by Wolfgang
>  * move mounted out of Enum and add filesystem string
>  * add missing zfsreserve usage type
>  * add 'mounted' column to disklist (separate patch[1])
> 
> 
> [1] https://lists.proxmox.com/pipermail/pve-devel/2022-June/053211.html
> 
> * proxmox-backup
> Hannes Laimer (3):
>   api2: disks endpoint return partitions
>   disks: use builder pattern for querying disk usage
>   ui: disks: show partitions by default
> 
>  src/api2/node/disks/directory.rs |   6 +-
>  src/api2/node/disks/mod.rs       |  19 ++-
>  src/api2/node/disks/zfs.rs       |   2 +-
>  src/tools/disks/mod.rs           | 206 +++++++++++++++++++++++++++++--
>  www/panel/StorageAndDisks.js     |   1 +
>  5 files changed, 215 insertions(+), 19 deletions(-)
> 
> * proxmox-widget-toolkit
> Hannes Laimer (1):
>   ui: DiskLisk: handle partition data from PBS backend
> 
>  src/panel/DiskList.js | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> -- 
> 2.30.2