[pbs-devel] [PATCH proxmox-backup] fix: config: remove duplicate privilege lookup in cached_user_info

Stefan Sterz s.sterz at proxmox.com
Fri Jun 10 11:00:20 CEST 2022


On 6/10/22 10:52, Wolfgang Bumiller wrote:
> Any reason for the "fix: " prefix in the commit message, though? This
> just seems to remove something redundant and not actually fix an issue?
> Or am I missing something?
> 
> Code-wise it seems fine, so I'd apply it, but I'd drop the 'fix' prefix?
> 

i can see your point in that this technically doesn't fix a bug. you
can remove it.

my reasoning was that it removes a performance loss (albeit a rather
minor one) and also potential confusion when reviewing this code in
the future. it tripped me up when i looked at it. at the very least it
makes the code here more concise.

-- snip --





More information about the pbs-devel mailing list