[pbs-devel] applied: [PATCH proxmox-backup] pbs-datastore: lookup: don't create new ChunkStore on datastore reopen

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 3 11:25:37 CEST 2022


Am 02/06/2022 um 16:27 schrieb Dominik Csapak:
> When re-opening a datastore, e.g. because the config changed or the
> last re-open was >60s ago, the chunkstore was also re-opened. Opening a
> ChunkStore creates a new ProcessLocker, so re-opening a datastore had the
> unintentional side-effect of potentially discarding the existing
> ProcessLocker. Any contained shared locks are lost in turn.
> 
> To fix this, reuse an old, existing ChunkStore (and its ProcessLocker)
> on the re-opened datastore, since only the datastore config should be
> reloaded, and the ChunkStore path is not updatable over our API anyway.
> If a user manually edited the path in the config, a daemon restart must
> happen for this change to take effect.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  pbs-datastore/src/datastore.rs | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)
> 
>

forgot to reply yesterday: applied and backported, thanks!





More information about the pbs-devel mailing list