[pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type

[Mira Limbeck]

On 7/21/22 13:46, Wolfgang Bumiller wrote:
> On Thu, Jul 21, 2022 at 01:32:32PM +0200, Thomas Lamprecht wrote:
>> Am 20/07/2022 um 16:20 schrieb Mira Limbeck:
>>> and encode the username:password string as base64 [0]. This fixes the
>>> error 407 issue when using proxy authentication [1].
>> does this break setups that configured "Basic base64-encoded-pw" themselves though,
>> or was that never possible (e.g., due to schema not allowing that)?
> That would break other things. Eg. `ProxyConfig;:to_proxy_string` uses
> it to build "http://<authorization>@<host>" strings, so the "Basic "
> prefix and base64 encoding would break those.
>
> However, we also build such headers in src/client/simple.rs which should
> will need the same change I suppose?

Do we want to make the authentication scheme, here `Basic`, configurable?