[pbs-devel] [PATCH proxmox-backup 07/26] api2: datastore create: don't init chunkstore if removable

[Hannes Laimer]

Am 06.07.22 um 13:35 schrieb Wolfgang Bumiller:
> On Tue, Jul 05, 2022 at 01:08:15PM +0000, Hannes Laimer wrote:
>> .. instead set the maintenance mode to unplugged. So on creation every
>> removable datastore is unplugged until a removable device is associated
>> with it.
> 
> As a continuation of my design question: if we were to include the
> removable device info right in the datastore, we could just drop the
> late initialization code altogether IMO.

Yes, but we will have to do it also in a another place as soon as we add
a seconds removable device. So by moving the initialization to the
mounting process we have it in just one place.
> 
> Actually, we can drop it regardless IMO. When do you really need to
> declare a datastore before adding the devices for it? Is that really
> something we need?

If we have a PBS and want to use a removable device that contains data
that was written by another PBS we have to be able to create a datastore
without creating the chunkstore on the device.