[pbs-devel] [PATCH proxmox-backup 02/26] config: make RemovableDeviceConfig savable to config file

[Hannes Laimer]

Am 06.07.22 um 13:44 schrieb Thomas Lamprecht:
> On 06/07/2022 13:33, Wolfgang Bumiller wrote:
>> Do we need this to be a separate config file though? Can this not simply
>> be part of the datastore directly? We already "link" them by having to
>> define the datastore as `removable`, so can we not just put all the
>> values in there?
> 
> IIRC we talked about adding just a "backing-device", or the like (probably
> something a bit more explicit w.r.t. to removable), property to existing
> datastores, and then pretty much handle them like existing ones.
> 
> That way we can reuse most of existing infrastructure and functionality,
> what changes is a different (or no) error on sync, GC, etc. (or repeat skipped
> jobs when plugged in) and the "auto-mount + activate in PBS" via udev helper.

Yes, we could put all the removable-device data directly into the
datastore config. But I think this is a cleaner and more flexible
approach, I guess you could argue similarly for why sync and prune jobs
have their own configs. What do you mean with we can't reuse
infrastructure with the own config approach? Sync/Prune/GC work like on
a normal datastore, just with the possibility of failing with "no
device present".

I think by having a removable-device as its own thing we actually end up
reusing more of the already existing API/UI functionality, because
having it directly in the datastore config would mean a lot of "manual"
parsing of property strings and a "custom" update/add implementation.