[pbs-devel] [PATCH proxmox-backup 23/26] api2: admin: add mount-device endpoint that just takes an UUID
Hannes Laimer
h.laimer at proxmox.com
Tue Jul 5 15:08:31 CEST 2022
... needed for auto mounting a removable device when it is plugged in
Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
---
src/api2/admin/mod.rs | 4 ++
src/api2/admin/removable_device.rs | 70 +++++++++++++++++++++++++++++-
2 files changed, 72 insertions(+), 2 deletions(-)
diff --git a/src/api2/admin/mod.rs b/src/api2/admin/mod.rs
index 00ff9131..09da6f2f 100644
--- a/src/api2/admin/mod.rs
+++ b/src/api2/admin/mod.rs
@@ -20,6 +20,10 @@ const SUBDIRS: SubdirMap = &sorted!([
("prune", &prune::ROUTER),
("sync", &sync::ROUTER),
("removable-device", &removable_device::ROUTER),
+ (
+ "mount-device",
+ &Router::new().post(&removable_device::API_METHOD_MOUNT_UUID_DEVICE),
+ ),
("traffic-control", &traffic_control::ROUTER),
("verify", &verify::ROUTER),
]);
diff --git a/src/api2/admin/removable_device.rs b/src/api2/admin/removable_device.rs
index 53b92ba7..54aee88f 100644
--- a/src/api2/admin/removable_device.rs
+++ b/src/api2/admin/removable_device.rs
@@ -5,14 +5,14 @@ use proxmox_router::{
list_subdirs_api_method, ApiMethod, Permission, Router, RpcEnvironment, RpcEnvironmentType,
SubdirMap,
};
-use proxmox_schema::api;
+use proxmox_schema::{api, param_bail};
use proxmox_section_config::SectionConfigData;
use proxmox_sys::{sortable, task_log, WorkerTaskContext};
use serde_json::Value;
use pbs_api_types::{
Authid, DataStoreConfig, RemovableDeviceConfig, RemovableDeviceStatus, DATASTORE_SCHEMA,
- DEVICE_NAME_SCHEMA, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_MODIFY,
+ DEVICE_NAME_SCHEMA, DEVICE_UUID_SCHEMA, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_MODIFY,
};
use pbs_config::{datastore, removable_device, BackupLockGuard, CachedUserInfo};
use pbs_datastore::ChunkStore;
@@ -202,6 +202,72 @@ pub fn mount_removable_device(
Ok(upid)
}
+#[api(
+ protected: true,
+ input: {
+ properties: {
+ uuid: {
+ schema: DEVICE_UUID_SCHEMA,
+ }
+ }
+ },
+ access: {
+ permission: &Permission::Anybody,
+ description: "Requires Datastore.Modify on removable devices's datastore.",
+ },
+)]
+/// Mounts removable device by uuid.
+pub fn mount_uuid_device(
+ uuid: String,
+ _info: &ApiMethod,
+ rpcenv: &mut dyn RpcEnvironment,
+) -> Result<String, Error> {
+ let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?;
+ let user_info = CachedUserInfo::new()?;
+
+ let lock = pbs_config::datastore::lock_config()?;
+ let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI;
+
+ let (section_config, _digest) = removable_device::config()?;
+ if let Some(device_config) = section_config
+ .convert_to_typed_array::<RemovableDeviceConfig>("removable-device")?
+ .into_iter()
+ .find(|c| c.uuid.eq(&uuid))
+ {
+ user_info.check_privs(
+ &auth_id,
+ &device_config.acl_path(),
+ PRIV_DATASTORE_MODIFY,
+ true,
+ )?;
+
+ let (datastore_section_config, _digest) = datastore::config()?;
+ let store: DataStoreConfig =
+ datastore_section_config.lookup("datastore", &device_config.store)?;
+
+ let upid = WorkerTask::new_thread(
+ "mount-device",
+ Some(store.name.to_string()),
+ auth_id.to_string(),
+ to_stdout,
+ move |worker| {
+ do_mount_removable(
+ lock,
+ section_config,
+ datastore_section_config,
+ store,
+ device_config,
+ Some(&worker),
+ )
+ },
+ )?;
+
+ Ok(upid)
+ } else {
+ param_bail!("uuid", "no removable device with uuid '{}' exists", uuid);
+ }
+}
+
#[sortable]
const DEVICE_INFO_SUBDIRS: SubdirMap = &[(
"mount",
--
2.30.2
More information about the pbs-devel
mailing list