[pbs-devel] applied: [PATCH v2 proxmox-backup] fix #3323: dry-run for cli backup subcommand

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Feb 18 15:10:20 CET 2022


On 18.02.22 10:55, markus frank wrote:
> From: Markus Frank <m.frank at proxmox.com>
> 
> adds a dry-run parameter for "proxmox-backup-client backup".
> With this parameter on it simply prints out what would be uploaded,
> instead of uploading it.
> 
> Signed-off-by: Markus Frank <m.frank at proxmox.com>
> ---
> version 2:
>  * tuple matching
>  * print closure
> 
>  proxmox-backup-client/src/main.rs | 50 +++++++++++++++++++++++++------
>  1 file changed, 41 insertions(+), 9 deletions(-)
> 
>

dropped one From header and applied, thanks!

Made two followups, one for the helper inline fn, i.e., repo was available in scope
so no need to pass it as param (question is if it's useful to repeat the same value
more than once anyway, but I kept it for now), and the second was for existing
non-ideal way the boolean/defaults where managed, the api macro is able to
handle that more comfortably and so that the default shows up in the CLI help.





More information about the pbs-devel mailing list