[pbs-devel] applied: [PATCH proxmox-backup v2] fix #3103. node config: allow to configure default UI language
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Feb 3 14:37:27 CET 2022
On 24.01.22 11:09, Matthias Heiserer wrote:
> This language is only used if none is set in the cookies.
>
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
> Changes from v1:
> Adhere to max length
> Remove trailing whitespace
> Use enum to store available translations
> Add language name to enum variants
> Rename chinese and portugese to same case as in i18 files
> Check for existance of translation file when using default language
>
> src/bin/proxmox-backup-proxy.rs | 9 ++++
> src/config/node.rs | 75 ++++++++++++++++++++++++++++++++-
> 2 files changed, 82 insertions(+), 2 deletions(-)
>
>
applied, thanks!
I dropped the need for `#[allow(non_camel_case_types)]` on the enu, as we
have a serde-rename on the affected members anyway, also cleaned up how the
proxy extracts the language stuff, as that was quite convoluted..
FYI, there's still something missing: the api is missing integration for
this in the node config update method, so setting it via API or via
`proxmox-backup-manager node update --default-language it` cannot work yet,
fixing that is quite trivial, can you please send a followup patch for that
and ideally also the GUI support?
More information about the pbs-devel
mailing list