[pbs-devel] [PATCH v3 proxmox-backup 1/4] debug cli: show more file attributes for `diff archive` command

Lukas Wagner l.wagner at proxmox.com
Fri Dec 9 11:45:58 CET 2022



On 12/9/22 10:13, Wolfgang Bumiller wrote:
>> +        (EntryKind::Device(a), EntryKind::Device(b)) => {
>> +            changed.content = a.major != b.major || a.minor != b.minor
> 
> Just noticed - we might be missing a change between blockdev/chardev
> here? Might need to include
> 
>      file_a.metadata().stat.is_blockdev() != file_b.metadata().stat.is_blockdev()
> 
> as well? Or am I missing this being handled elsewhere already?> 

Yes, you are absolutely correct, this is something that I've missed here. Will be fixed in the next
version of the patch series.

-- 
Best Regards,
Lukas Wagner





More information about the pbs-devel mailing list