[pbs-devel] applied: [PATCH proxmox] build: use weak and namespaced features

[Thomas Lamprecht]

Am 22/08/2022 um 11:24 schrieb Fabian Grünbichler:
> to reduce the creep of optional dependencies being exposed as features.
> 
> this requires cargo 0.63 (and debcargo built against at least that
> version), but greatly reduces the number of binary packages and provides
> generated, while still allowing sensible selection of optional
> dependencies via the explicit feature meant for pulling them in.
> 
> diff stat for running `make  deb` after this change:
>  proxmox-http/debian/control         | 226 ++++--------------------------------
>  proxmox-router/debian/control       |  74 +-----------
>  proxmox-schema/debian/control       |  53 ++-------
>  proxmox-subscription/debian/control |  17 +--
>  proxmox-sys/debian/control          |  51 +++-----
>  proxmox-tfa/debian/control          | 110 ++----------------
>  6 files changed, 72 insertions(+), 459 deletions(-)
> 
> the 'dep:' prefix marks something on the RHS inside the features section
> as dependency, it's only allowed if the string after it is an optional
> dependency an no explicit feature of the same name exists. if all
> pointers to the optional dependency in the features section are marked
> as such, the optional dependency itself will not be exposed as a feature
> (either on the cargo or debian/control level).
> 
> the '?' suffix marks dependencies as "weak", which only enables the
> optional dependency + its feature(s) if the optional dependency itself
> is also enabled. it has no effect on d/control since such a relationship
> is not encodable in Debian package relations, but it does affect cargo
> dependency resolution and allows skipping the build of unneeded optional
> dependencies in some cases.
> 
> with no packages/crates depending on the no longer exposed automatically
> generated features/packages, so these are safe to remove even though
> it's technically a breaking change.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> sent as patch to wait for cargo 0.63 regressions before applying
> 
>  proxmox-http/Cargo.toml         | 26 ++++++++++++++------------
>  proxmox-router/Cargo.toml       |  2 +-
>  proxmox-schema/Cargo.toml       |  4 ++--
>  proxmox-subscription/Cargo.toml |  2 +-
>  proxmox-sys/Cargo.toml          |  4 ++--
>  proxmox-tfa/Cargo.toml          |  6 +++---
>  6 files changed, 23 insertions(+), 21 deletions(-)
> 
>

applied, thanks!