[pbs-devel] applied-series: [PATCH proxmox-backup v2 0/6] improve UI for maintenance mode

[Thomas Lamprecht]

On 26.04.22 08:23, Hannes Laimer wrote:
> Adds mask for datastore summary when in maintenance mode and dynamically
> updates icon and tooltip in datastore list. The 4th patch is optional,
> and could be squashed with the 3rd path if applied, it would make the
> icon update more responsive and not that delayed, but not sure if that is
> even a problem.
> 
> v2, thanks @Fabian + @Thomas:
>  - fix backwards compat. for DataStoreListItem
>  - add parse function for maintenance mode to utils
>  - show tooltip (<type>[: <message>]) in datastore list
>  - use icon itself instead of .svg for wrench
> 
> Hannes Laimer (6):
>   ui: add summary mask when in maintenance mode
>   api2: DataStoreListItem add maintenance info
>   ui: update icon in datastore list when in maintenance mode
>   ui: update datastore list more often
>   ui: utils: add function for parsing maintenance mode
>   ui: add tooltip to datastore in maintenance mode
> 
>  pbs-api-types/src/datastore.rs   |  8 ++++++
>  src/api2/admin/datastore.rs      |  1 +
>  www/NavigationTree.js            | 45 ++++++++++++++++++++++++++------
>  www/Utils.js                     | 17 +++++++++---
>  www/css/ext6-pbs.css             | 32 +++++++++++++++++++++++
>  www/datastore/Summary.js         | 21 ++++++++++++++-
>  www/window/MaintenanceOptions.js |  8 ++----
>  7 files changed, 113 insertions(+), 19 deletions(-)
> 



applied, looks quite nice now, thanks!

two nits/possible improvements:

* if I put the datastore in offline mode, then go to the content tab I get the view masked
  with the "datastore in maintenance mode" error, so far so good. Now, if I disable maintenance
  mode again and switch back to the content tab (wihtout navigating anywhere else) I still see
  that view masked with the same error, even if I waited for 10s or so. It helps to either navigate
  to some other navigation element (e.g., another datastore or "Administration") and then back again
  so no "biggie" but maybe we could see if the mask can be cleared more actively. 

* w.r.t. the increased frequency we poll now the datastore list for the navigation status/icon:
  maybe we could keep the previous 15s period and just do one extra reload on setting the
  maintenance mode, after all it's quite likely that not many admins are online at the same time
  and the most important one to get immediate feedback is for the one who set the maintenance mode
  in the first place.

as said, just nits but they stuck somewhat out to me.