[pbs-devel] applied: [PATCH proxmox-backup v5 5/5] fix #3067: ui: add a separate notes view for longer markdown notes

[Thomas Lamprecht]

On 12.04.22 12:34, Stefan Sterz wrote:
> since markdown notes might be rather long, this commit adds a tab
> similar to pve's datacenter or node notes. requires a bump of the
> widget toolkit in order to use the `pmxNotesView`.
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
> i chose the maxLength of a note in pbs to be 1022*64 because the
> server allows at most 1024*64 bytes of form data per request, which
> are distributed as follows:
> 
> equal signs:             2
> the word "digest":       7
> digest:                  64
> the word "description":  12
> description:             65451
> 
> so by setting the limit to 1024*64 some users might encounter an
> error telling them that the message body was too large even though the
> front-end said the description was fine. i wanted to approximate
> the 1024*64 limit here as close as possible so i chose:
> 65451 / 64 ~ 1022.
> 
> note that afaict due to the way maxLength is implemented the frontend
> might not report an error when it should. this is due to character
> encodings and how javascript's string length property works.
> 
>  www/Makefile          |  1 +
>  www/NavigationTree.js |  6 ++++++
>  www/NodeNotes.js      | 23 +++++++++++++++++++++++
>  3 files changed, 30 insertions(+)
>  create mode 100644 www/NodeNotes.js
> 
>

applied, thanks!