[pbs-devel] [PATCH proxmox-backup v2 0/4] refactor datastore locking to use tmpfs
Stefan Sterz
s.sterz at proxmox.com
Wed Apr 13 11:11:47 CEST 2022
This series refactors the locking mechanism inside the `DataStore`
trait. In a first step locking methods are added and the existing
code is refactored to use them. The second commit then adds double
stat'ing and adds lock files under '/run' for each group/snapshot.
The third commit refactors locking for manifests and brings it in-line
with the group/snapshot locks. Finally the fourth commit fixes a race
condition when changing the owner of a datastore.
changes from v1 (thanks @ Wolfgang Bumiller & Thomas Lamprecht):
* split adding locking helpers and move '/run' into two commits
* instead of stat'ing the path of lock file twice, only use the file
descriptor for one of the stat'ing procedures instead
* several improvements to helper functions and documentation
Stefan Sterz (4):
fix #3935: datastore/api/backup: add locking helpers to datastore
fix #3935: datastore/api/backup: move datastore locking to '/run'
fix #3935: datastore: move manifest locking to new locking method
fix: api: avoid race condition in set_backup_owner
pbs-config/src/lib.rs | 7 +
pbs-datastore/src/datastore.rs | 190 +++++++++++++++++++--------
pbs-datastore/src/snapshot_reader.rs | 30 +++--
src/api2/admin/datastore.rs | 9 +-
src/api2/backup/environment.rs | 4 +-
src/api2/backup/mod.rs | 4 +-
src/api2/reader/mod.rs | 7 +-
src/backup/verify.rs | 12 +-
8 files changed, 180 insertions(+), 83 deletions(-)
--
2.30.2
More information about the pbs-devel
mailing list