[pbs-devel] applied-series: [PATCH proxmox-backup v10 0/6] closes #3071: maintenance mode for datastore

[Thomas Lamprecht]

On 12.04.22 07:25, Hannes Laimer wrote:
> Hannes Laimer (6):
>   api-types: add maintenance type
>   datastore: add check for maintenance in lookup
>   pbs-datastore: add active operations tracking
>   api: make maintenance_type updatable
>   api: add get_active_operations endpoint
>   ui: add option to change the maintenance type
> 
>  pbs-api-types/Cargo.toml             |   2 +-
>  pbs-api-types/src/datastore.rs       |  23 ++++-
>  pbs-api-types/src/lib.rs             |   3 +
>  pbs-api-types/src/maintenance.rs     |  78 +++++++++++++++++
>  pbs-datastore/Cargo.toml             |   1 +
>  pbs-datastore/src/datastore.rs       | 126 +++++++++++++++++++--------
>  pbs-datastore/src/lib.rs             |   4 +
>  pbs-datastore/src/snapshot_reader.rs |   6 +-
>  pbs-datastore/src/task_tracking.rs   | 110 +++++++++++++++++++++++
>  src/api2/admin/datastore.rs          |  81 +++++++++++------
>  src/api2/backup/mod.rs               |   4 +-
>  src/api2/config/datastore.rs         |   5 ++
>  src/api2/reader/mod.rs               |   6 +-
>  src/api2/status.rs                   |   4 +-
>  src/api2/tape/backup.rs              |   6 +-
>  src/api2/tape/restore.rs             |   6 +-
>  src/bin/proxmox-backup-api.rs        |   1 +
>  src/bin/proxmox-backup-proxy.rs      |   4 +-
>  src/server/mod.rs                    |  16 +++-
>  src/server/prune_job.rs              |   4 +-
>  src/server/pull.rs                   |   4 +-
>  src/server/verify_job.rs             |   4 +-
>  www/Makefile                         |   1 +
>  www/Utils.js                         |  23 +++++
>  www/datastore/OptionView.js          |  30 +++++++
>  www/window/MaintenanceOptions.js     |  77 ++++++++++++++++
>  26 files changed, 539 insertions(+), 90 deletions(-)
>  create mode 100644 pbs-api-types/src/maintenance.rs
>  create mode 100644 pbs-datastore/src/task_tracking.rs
>  create mode 100644 www/window/MaintenanceOptions.js
> 


applied series, thanks!

In the UI I fixed the leaking of the tasks tracking storage (needed an explicit stop on
deactivate/destroy event of the option view panel like we had for the existing rstore)
and also patched the renderer to show also the message inline.

What's still missing, or up for improvement:
* show the maintenance mode in the datastore summary (or just plainly in the
  "Datastore: <name>" heading of the panel?); as currently it's rather subtle

* Improve failure mode in offline mode, e.g., the summary page then is just plank/broken
  and the content view shows a loading error/mask that won't get removed until reload
  even if one reset the maintenance mode to none again, at least FWICT

Both mostly cosmetical, but quite important IMO for UX and to avoid user confusion.